Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples #1093

Closed
wants to merge 2 commits into from
Closed

Update examples #1093

wants to merge 2 commits into from

Conversation

birkskyum
Copy link
Contributor

@birkskyum birkskyum commented Oct 24, 2023

I updated all the examples dependencies to their latest versions, still within Node 18. This is a preparation step towards Node 20 which now is the current LTS.

I identified that the tRPC example is breaking (and using archived packages), so I didn't touch that. Reported it here instead

I identified that the following examples will be challenging when moving to Node 20, because start-cloudflare-worker isn't compatible with Node 20 atm:

  • notes
  • with-websocket

For the authjs example, @solid-auth/base is archived and moved to @solid-mediakit/auth, so I updated the dependencies to reflect that. Might help with: #1007

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@sysmat
Copy link

sysmat commented Nov 1, 2023

looking forward

@birkskyum
Copy link
Contributor Author

Let me know if it's of interest and will be reviewed - then I'd be happy to rebase this PR.

@birkskyum
Copy link
Contributor Author

The diff has grown too large - needs a remake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants